Closed UEWBot closed 1 year ago
I think we can add a new method to RoundPlayer - is_drop_round(). Should be possible to figure that out
Actually, a boolean score_dropped that is initialized to false and can be changed to true when calculating the tournament score. It will never need to be set back to true. Actually, it could be set back to true because a player could be doing well in a game, which means a good "if all games ended now" score but then do worse such that their score for that game, and hence round, drops below an earlier round.
Taking the same approach with GamePlayer would also help with league scoring, where we may want to count multiple games from one round.
It would also be useful to distinguish final (locked) scores from “if it ended now” scores (game, round, and tournament).
So we have a number of different scores:
<span>
is the CSS element to use where we have additional text in the element
This will be easier if we first do issue #234, because when that is done we will probably pass actual GamePlayer, RoundPlayer, and TournamentPlayer objects to the templates, rather than values extracted from them.
Commit 8966e775c6afd35adcadaef9b85bcd7440191ed6 makes "if all games ended now" scores italic.
Commit c7f48d8a072d5c4b86d2e20e431b46d90b4546b6 shows which round scores don't contribute to the tournament score and which game scores don't contribute to the round score. If scores are entered manually, this could leave some odd results, unless the admin is used to set the score_dropped attributes, too. I don't think that's a big deal - manually-entered scores are very rare.
Where players have a drop round, it would be nice if the score listing actually showed which round is dropped (probably by colour).