UEWBot / dipvis

Django-based visualiser for tournaments for the boardgame Diplomacy
GNU General Public License v3.0
7 stars 5 forks source link

Diplomacy refactor #227

Closed jasonmastbaum closed 2 years ago

UEWBot commented 2 years ago

Something about this breaks the unit tests - seems that they're all not found (even the ones that aren't changed)

UEWBot commented 2 years ago

Aha! https://stackoverflow.com/questions/21069880/running-django-tutorial-tests-fail-no-module-named-polls-tests says that there shouldn't be an __init__.py in the visualiser directory, and indeed deleting that does seem to fix python3 ./manage.py test, although there are still some failures - looks like some of the other test imports need changing to reflect the new structure

jasonmastbaum commented 2 years ago

I was updating the imports by iteratively doing manage.py runserver, fixing the file it complained about, repeated until it successfully did the runserver. Good reminder that I need to do the tests too.

UEWBot commented 2 years ago

Yeah, the unit tests are actually quite good at picking up regressions. Definitely useful for this kind of work

UEWBot commented 2 years ago

Finally merged