search

UEWBot / dipvis

Django-based visualiser for tournaments for the boardgame Diplomacy
GNU General Public License v3.0
7 stars 5 forks source link

Game doesn't auto-complete at end of final year #230

Closed UEWBot closed 2 years ago

UEWBot commented 2 years ago

At Cascadia, round 3 games were set to end at the end of 1908. Centre ownership was imported from Backstabbr. The one round 3 game that didn't draw also didn't flag itself as finished, even after the '08 centre ownerships were imported.

UEWBot commented 2 years ago

Game.check_whether_finished() looks suspicious - comparison with self.final_year. game_views.scrape_backstabbr() calls Game.check_whether_finished(), passing the year that was scraped. We don't seem to have tests for Game.check_whether_finished().