UEWBot / dipvis

Django-based visualiser for tournaments for the boardgame Diplomacy
GNU General Public License v3.0
7 stars 5 forks source link

Sitting out bonus doesn't work well with TScoringSumGames() #315

Open UEWBot opened 3 weeks ago

UEWBot commented 3 weeks ago

We do have RoundScoringSystems with a "sitting out bonus" that is points given to players who agree not to play to make the numbers work. That's fine where we have a TournamentScoringSystem that sums the best N Rounds.

When we have TScoringSumGames(), though, we ideally want to treat the "sitting out bonus" as a Game score.

We probably need to split the "sitting out bonus" out from the RoundScoringSystem, too, because ideally with TScoringSumGames() we have a RoundScoringSystem of "None". Perhaps it needs to become an attribute of the Tournament instead?

UEWBot commented 3 weeks ago

Maybe we need a class just for the sitting out bonus given to a player. If it had the right attributes, we could treat it as a GamePlayer when calculating scores.