UEWBot / dipvis

Django-based visualiser for tournaments for the boardgame Diplomacy
GNU General Public License v3.0
7 stars 5 forks source link

RoundPlayer.score_is_final() with TScoringSumGames #319

Open UEWBot opened 3 weeks ago

UEWBot commented 3 weeks ago

This function sometimes returns False when it should strictly return True. For example consider a 3 round tournament, with best 2 games scoring full points and any others scoring half the average. Consider a player playing one game each round, with the third round ongoing. We know for sure that their best score from the first two rounds will count fully, because however the final game goes, it's one of the best two. So the function should return True for that round but will currently return False.