search

UFGInsurance / mulint

Mule project linter
MIT License
6 stars 0 forks source link

Warning for static port setting #62

Closed joy20man closed 5 years ago

joy20man commented 5 years ago

[warning] Global acc-claim-system-api_HTTPS_Request port: expected matching /^\${.+}$/ but was "443" [warning] Global acc-base-proxy_HTTPS_Request port: expected matching /^\${.+}$/ but was "443"

Since this value is always going to be 443 it doesn't seem appropriate to force it to be parameter. Recommend an exception allowing default port of 443 on request configurations.

TrueWill commented 5 years ago

@joy20man Thanks for opening this! I'm checking with the C4E before making the change.

UKachegere commented 5 years ago

@joy20man @TrueWill
It is true that the https.port variable in properties file is used by http requests within a flow to other API's. While in most instances the value is always standard https port 443, in case of UFG depending number of domain projects used, the ports will be different for API's hosted in mulesoft.

TrueWill commented 5 years ago

@joy20man As @UKachegere mentioned, we're considering moving to multiple domain projects, which means that (per @aoathout ) a Mule server would be listening on different ports for each domain project. For external calls we'd reroute traffic.

This means that the port can change, so please continue to use parameters. Thank you!