search

UFRN-URNAI / urnai-tools

A modular Deep Reinforcement Learning library that supports multiple environments, made with Python 3.6.
Apache License 2.0
5 stars 8 forks source link

Finish unit tests for ActionSpaceBase #105

Open CinquilCinquil opened 4 weeks ago

CinquilCinquil commented 4 weeks ago

The ActionSpaceBase class is missing a test for the get_actions_id method.

RickFqt commented 3 weeks ago

Are we still going to use the ActionBase and ChainOfActionBase classes? I recall from some meetings ago that if we were to use ActionBase for example, we would have to create one subclass for each of the actions we would want to use (and that would be a lot of sublcasses). Then, at least for StarCraft2, we created SC2Action to avoid this problem. Is that right?

If so, in ActionSpaceBase, I think we should replace ActionBase with int, that would represent the actions' indices. Also, we would have to change the implementation of get_actions_id method, since it relies on ActionBase too. What do you think?

CinquilCinquil commented 3 weeks ago

I recall we had to create SC2Action for StarCraft2, but i don't remember the conclusions we had for the Action classes in general in URNAI. It doesn't seem correct to me to modify the entire library, abandoning ActionBase and ChainOfActionBase, just to fit the sc2 environment.

I think this is a good topic to discuss in the next meeting.