search

UFRN-URNAI / urnai-tools

A modular Deep Reinforcement Learning library that supports multiple environments, made with Python 3.6.
Apache License 2.0
5 stars 8 forks source link

Resolves #68 #88

Closed CinquilCinquil closed 4 months ago

alvarofpp commented 4 months ago

Please rebase your branch.

CinquilCinquil commented 4 months ago

I tried, but it apparently isn't recognizing that the 15 commits i did in issue-67 are already in the v2. I think its because those commits are all squashed inside a commit called "Resolves #67 (#79)". So when i try to rebase, it asks me to solve all of them manually (wich i don't think is the right way), like its treating them as totally new commits, despite the fact that they arrive at the same end result.

What i thought about doing was saving my changes locally, then deleting this branch and creating it again with the right base, after that commit my changes again, since they weren't that big. What do you think @alvarofpp ?

alvarofpp commented 4 months ago

@CinquilCinquil

  1. Close this PR (#88);
  2. Create a new branch from the v2 branch;
  3. Run cherry-pick for your commits in the issue-68 branch;
  4. Open a new PR with the changes from the branch created in step 2.