search

UG4 / plugin_ProMesh

Interface and extensions to the meshing routines provided by ugcore/lib_grid.
4 stars 5 forks source link

SelectEdgeByProjectedCoordinate #11

Closed mastep84 closed 3 years ago

mastep84 commented 3 years ago

Added function 'SelectEdgeByProjectedCoordinate' selecting the edge for which the specified coordinate is closest to its perpendicular projection onto this edge.

sreiter commented 3 years ago

What you're caclulating is not necessarily the distance to the projected point. If the projection lies outside of a line segment, the distance to the closest endpoint of the line segment (edge) is computed. The naming is somewhat misleading and probably unnecessarily complex, I guess.

Why not simply SelectClosestEdge?

mastep84 commented 3 years ago

Dear Sebastian,

thank you for your review -- indeed, the naming was somewhat misleading. I have applied modifications according to your suggestions streamlining the code.

Best regards, Martin

sreiter commented 3 years ago

Dear Martin,

I'm sorry that it took so long to merge your request. Thanks for taking the time to consider my comments :)

Best, Sebastian