search

UG4 / ugcore

The core functionality of UG4. Includes sources, build-scripts, and utility scripts.
https://github.com/UG4/ugcore
Other
36 stars 23 forks source link

Segmentation fault in adaptive refinement #35

Closed stephanmg closed 3 years ago

stephanmg commented 3 years ago

I'm receiving a segmentation fault when using adaptive refinement, see and review pull request #33

Is this the appropriate fix? If so would be great to merge it into master.

stephanmg commented 3 years ago

@anaegel can this issue be closed?

anaegel commented 3 years ago

The fix looks good to me. However, right now, I cannot confirm that this works with all tests in the test suite. If everything is working for you, please feel free to close. We can still revisit later.

stephanmg commented 3 years ago

Okay, I will see if I've time to verify all tests work later today. If not (either case), I'll keep this issue open.

bsumirak commented 3 years ago

Seems to me this was the proper fix for the issue. In any case, tests involving the code can hardly do worse than before.