search

UG4 / ugcore

The core functionality of UG4. Includes sources, build-scripts, and utility scripts.
https://github.com/UG4/ugcore
Other
36 stars 23 forks source link

Missing/undesired dependencies in ugcore #52

Open LogashenkoDL opened 3 years ago

LogashenkoDL commented 3 years ago

There are lua and shell scripts in ugcore that contain some references to plugins (that should be avoided) or to local servers (where the access is restricted).

  1. ugcore/scripts/util/domain_disc_util.lua refers to particular classes (of discretizations) implemented in plugins ConvectionDiffusion and NavierStokes (which are at least published) as well as d3f (which is completely internal, unpublished). The main idea of all those functions is however to all a further suffix (FV1, FE, ...) to the class. Can one implement this in a more general way, not referring to particular plugins?
  2. ugcore/scripts/shell/uginstall mentions server fuji.gcsc.uni-frankfurt.de and IP 141.2.38.55. Both are not working any more. Note the fuji is mentioned as a svn server. Are we still using svn in any way? Can somebody review the my_download_file, my_download, my_install_external_build and my_install functions in this script and decide if we need them in this form?
  3. ugcore/scripts/shell/uginstall provides some routines to install software required by plugins, e.g. SuperLU. (Note that the SuperLU plugin is not published!) This should probably be moved to the corresponding plugins. Note that the make_SuperLU function mentions publicly servers cekon.gcsc.uni-frankfurt.de and cesari.gcsc.uni-frankfurt.de, and is probably not the proper practice.
stephanmg commented 3 years ago

ad 1.: Could one abstract domain_disc_util.lua and provide specific implementations in the corresponding apps for the plugins? Perhaps it's possible to provide one general domain_disc_util.lua as well.

ad 3.: Could these dependencies be moved into the plugins?

LogashenkoDL commented 1 year ago

Part 1. is resolved: Following the ideology and tools introduced by T. Schön and A. Nägel, the plugin-dependent parts are moved to the lua/lua-include.lua files of the corresponding plugins.