Teaching Kits - Githubissues

UGS-GIO / Website

UGS Website

0 stars 0 forks source link

Teaching Kits #13

Closed Mackenzie-Cope closed 2 years ago

Mackenzie-Cope commented 4 years ago

This will replace the current Teaching Kits page https://geology.utah.gov/teachers/teaching-kits/

Preview Link: https://geology.utah.gov/?page_id=51481&preview=1&_ppp=79c41cbeb4

Mackenzie-Cope commented 4 years ago

@jackie-dewolfe We should create new images to go with the kits. I'm thinking if we take some new photos of the contents of a kit, you can put them together in uniform mini banners? What do you think? I could go into the office one of these days and take a bunch of photos of the kits.

Mackenzie-Cope commented 4 years ago

Once we have new images, we need to take the code from all those 2/5 elements and make them 1/2s so there's no gap at the top.

Mackenzie-Cope commented 2 years ago

Might not need the code anymore if that covid message is going to stay up.
We should get photos of the glacier model, globe, and stream table too.

Mackenzie-Cope commented 2 years ago

[x] All Links Checked
[x] Design Uniformity
[x] Mobile Accessibility
[x] Photo Captions
[x] Mobile SLM Correct

marshallrobinson commented 2 years ago

Love the new design and pictures. Well done! A couple suggestions:

[x] I was confused when reading "Contain" at the beginning of each teaching kit. It makes sense when beginning the sentence with the plural teaching kit, but my eye treated the teaching kit name as a title and the text underneath it as its own sentence. I suggest changing each teaching kit (and other check-out-able items) name to singular and "Contain" (or "Include") to "Contents:" (If this ends up not looking good, please don't do it :)..)
[x] Personal preference here, but I suggest a little more white-space between the titles and text on the "Stream Tables," "Glacier Model," and "Plate Tectonics Globe" elements.

Mackenzie-Cope commented 2 years ago

The old text was in more of a sentence/paragraph format and now its more like a title so I see what you mean. I've modified the formatting to a title and description with "Contains" to make more sense. Good catch, Marshall.
fixed the spacing issue. Using a "content slider" element instead of "testimonial"

mikehylland commented 2 years ago

Looks good to me!