search

UGS-GIO / geolMapPortal

UGS Geologic Map Portal that compiles a large collection of geologic map data and displays it on an interactive web map
https://geomap.geology.utah.gov
1 stars 1 forks source link

Strat column edits clinton #106

Closed clintonlunn closed 1 month ago

clintonlunn commented 2 months ago

placeholder for lance to view

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 3907c8d):

https://ut-dnr-ugs-geolmapportal-prod--pr106-strat-column-edit-lj3hz80a.web.app

(expires Mon, 14 Oct 2024 16:20:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b1b618d1ec9921197df448bed38d327c8bbf53b2

jjhi11 commented 2 months ago

@clintonlunn review please

marshallrobinson commented 2 months ago

@Mackenzie-Cope let's tag-team this review as this release will be the first one to be hosted on Firebase.

Mackenzie-Cope commented 1 month ago

Marshall and Mackenzie comments:

  1. Search function for quadrangles is not working - shows an empty popup
  2. Unit search: Highlighted search results do not show unit descriptions when clicked. Unit descriptions DO work outside of highlighted areas.
  3. Streets and reference layer loading issue, console error.
  4. Map download popup: shareable map link not copying any link
  5. Map download popup: x-section icon missing
  6. Map download popup: pub reference (at bottom of card) is missing scale number and says "undefined"
  7. Strat columns popup on map: Change wording to "30' x 60' stratigraphic column for UGS Publication [series ID]" and "Open in a new tab"
  8. Beaver quad strat column centroid is not centered in the 30x60 quad.
marshallrobinson commented 1 month ago

Marshall and Mackenzie comments:

  1. Search function for quadrangles is not working - shows an empty popup
  2. Unit search: Highlighted search results do not show unit descriptions when clicked. Unit descriptions DO work outside of highlighted areas.
  3. Streets and reference layer loading issue, console error.
  4. Map download popup: shareable map link not copying any link
  5. Map download popup: x-section icon missing
  6. Map download popup: pub reference (at bottom of card) is missing scale number and says "undefined"
  7. Strat columns popup on map: Change wording to "30' x 60' stratigraphic column for UGS Publication [series ID]" and "Open in a new tab"
  8. Beaver quad strat column centroid is not centered in the 30x60 quad.

Thanks for squashing most of these bugs (4 and 5 look like the only ones left). Great progress! I took a stab in item #8 (see below)

  1. The Beaver quad's centroid is fixed. I took care of it in the postgres function.

Additional comments:

1. Line 555 (copyright: "lance weaver",): change copyright to "Utah Geological Survey" 2. Lines 585-622 (// Adds national... through ...// addStratCols();): please remove 3. Line 675 (// if (item == "stratCols"...)): please remove 4. Line 560 (definition expression of series_ids): remove "m-292" (will add later) 5. LaSal strat column (newly added to definition expression list on line 560) doesn't work. 6. Please address Clinton's review comments as well if you haven't already. Thanks

(not sure why the bolding and asterisks are formatting all weird)