UGS-GIO / wetlands

UGS Wetlands web application that compiles a large data set of Utah wetlands data and displays is on an interactive web map
https://geology.utah.gov/apps/wetlands/index.html
0 stars 0 forks source link

MOTH changes #70

Closed jjhi11 closed 1 year ago

jjhi11 commented 1 year ago

Issues 62, 64, 66, 69 and partially 61 addressed @marshallrobinson @wetlandsDiane @PeteGoodwinUGS please review here https://geology.utah.gov/apps/wetlands/review/index.html

wetlandsDiane commented 1 year ago

Thanks for making the updates. I organized my review by the github issue number.

61

I think the NWI data shown on this version of the app comes from NWI directly. It seems to me like it loads slower than the old way we were serving up the data and it took me a while to figure out why the data weren't displaying until I zoomed in far enough. We talked about going back to using the old method of getting the NWI data into the app, but spruced up with some simple code. Can we revert back to the old version of the NWI data for now (since it loads faster) and then come back to this issue when I have a chance to create some code to get the NWI data processed and ready for the app?

62

I will leave this to Pete for a more in-depth review but I noticed two things. There is a typo in the pop-up for the LLWW Popup for LLWW descriptions- the word "Attributes" is misspelled Also, I think when you download the data, the data explanation file should probably be a pdf doc.

64- looks good

66- looks good

69- looks good

Thanks!

On Thu, Jan 26, 2023 at 10:46 AM Jay Hill @.***> wrote:

Issues 62, 64, 66, 69 and partially 61 addressed @marshallrobinson https://github.com/marshallrobinson @wetlandsDiane https://github.com/wetlandsDiane @PeteGoodwinUGS https://github.com/PeteGoodwinUGS please review here https://geology.utah.gov/apps/wetlands/review/index.html

You can view, comment on, or merge this pull request online at:

https://github.com/UGS-GIO/wetlands/pull/70 Commit Summary

File Changes

(2 files https://github.com/UGS-GIO/wetlands/pull/70/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/UGS-GIO/wetlands/pull/70, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3KRTS2O6LDPCKFYUVQRW3WUKZ5PANCNFSM6AAAAAAUHY6YHM . You are receiving this because you were mentioned.Message ID: @.***>

--

[image: Photo] [image: Facebook icon] https://facebook.com/UTGeologicalSurvey[image: Twitter icon] https://twitter.com/utahgeological[image: Instagram icon] https://www.instagram.com/utahgeologicalsurvey/[image: LinkedIn Icon] https://www.linkedin.com/company/utah-geological-survey

Diane Menuz State Wetlands Coordinator O: (801) 538-7436 E: @.***

Utah Department of Natural Resources Utah Geological Survey

geology.utah.gov