Closed jjhi11 closed 1 year ago
Thanks for making the updates. I organized my review by the github issue number.
I think the NWI data shown on this version of the app comes from NWI directly. It seems to me like it loads slower than the old way we were serving up the data and it took me a while to figure out why the data weren't displaying until I zoomed in far enough. We talked about going back to using the old method of getting the NWI data into the app, but spruced up with some simple code. Can we revert back to the old version of the NWI data for now (since it loads faster) and then come back to this issue when I have a chance to create some code to get the NWI data processed and ready for the app?
I will leave this to Pete for a more in-depth review but I noticed two things. There is a typo in the pop-up for the LLWW Popup for LLWW descriptions- the word "Attributes" is misspelled Also, I think when you download the data, the data explanation file should probably be a pdf doc.
Thanks!
On Thu, Jan 26, 2023 at 10:46 AM Jay Hill @.***> wrote:
Issues 62, 64, 66, 69 and partially 61 addressed @marshallrobinson https://github.com/marshallrobinson @wetlandsDiane https://github.com/wetlandsDiane @PeteGoodwinUGS https://github.com/PeteGoodwinUGS please review here https://geology.utah.gov/apps/wetlands/review/index.html
You can view, comment on, or merge this pull request online at:
https://github.com/UGS-GIO/wetlands/pull/70 Commit Summary
- 45f47b3 https://github.com/UGS-GIO/wetlands/pull/70/commits/45f47b3b399b92d5d14d985847b3e1d06e44c46e remove boundary layer
- 5426a8f https://github.com/UGS-GIO/wetlands/pull/70/commits/5426a8f4ea743a5fcc58e325d57dd52e437ba058 removed boundaries from about panel
- 8ce60cb https://github.com/UGS-GIO/wetlands/pull/70/commits/8ce60cb49ef5cbca2ade231e3d4c077568beb126 Change names of wetland & rip metadata issue#64
- 2bd96ea https://github.com/UGS-GIO/wetlands/pull/70/commits/2bd96ead8b59b5724367afe05b7a2608b8fbc60d link to database panel in info panel issue #66
- 353a8ab https://github.com/UGS-GIO/wetlands/pull/70/commits/353a8ab16954902d41df107456dd7ea19f5f53af layer info added
- 44d6e52 https://github.com/UGS-GIO/wetlands/pull/70/commits/44d6e5245a9663d117b0baa62bd2d6a63ae54a21 llww layers added
- 8bc4a14 https://github.com/UGS-GIO/wetlands/pull/70/commits/8bc4a14a57d4022f97c72060089cf3753690ed34 llww symbology working
- 24f97a8 https://github.com/UGS-GIO/wetlands/pull/70/commits/24f97a8496c2076358d498ea04d8389753f38cfa LLWW Descriptions popup working
- f5ff6e7 https://github.com/UGS-GIO/wetlands/pull/70/commits/f5ff6e76c337d6ec130c9408dff78bb1bef317dc llww mapping areas popup working
File Changes
(2 files https://github.com/UGS-GIO/wetlands/pull/70/files)
- M index.html https://github.com/UGS-GIO/wetlands/pull/70/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051 (7)
- M map.js https://github.com/UGS-GIO/wetlands/pull/70/files#diff-3d5c8fd7f25f45ade45f26c8ba4beece327956f5fdaeb95e0a814ee6eab38cc5 (313)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/UGS-GIO/wetlands/pull/70, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3KRTS2O6LDPCKFYUVQRW3WUKZ5PANCNFSM6AAAAAAUHY6YHM . You are receiving this because you were mentioned.Message ID: @.***>
--
[image: Photo] [image: Facebook icon] https://facebook.com/UTGeologicalSurvey[image: Twitter icon] https://twitter.com/utahgeological[image: Instagram icon] https://www.instagram.com/utahgeologicalsurvey/[image: LinkedIn Icon] https://www.linkedin.com/company/utah-geological-survey
Diane Menuz State Wetlands Coordinator O: (801) 538-7436 E: @.***
Utah Department of Natural Resources Utah Geological Survey
geology.utah.gov
Issues 62, 64, 66, 69 and partially 61 addressed @marshallrobinson @wetlandsDiane @PeteGoodwinUGS please review here https://geology.utah.gov/apps/wetlands/review/index.html