search

UGentBiomath / COVID19-Model

Compartmental SEIQRD model to model the effects of government policies on SARS-CoV-2 spread in Belgium. Macro-economic Input-Output model to assess the economic impact of sector closure and changes in consumption patterns. Quality-adjusted life-years model to assess the health economic impact of SARS-CoV-2.
MIT License
22 stars 30 forks source link

'ICU' is both parameter as well as variable name #49

Closed stijnvanhoey closed 4 years ago

stijnvanhoey commented 4 years ago

When checking the code to try out the refactoring as described in https://github.com/UGentBiomath/COVID19-Model/issues/42, I noticed ICU is used both as parameter as well as variable. As such, ICU takes the value of the variable.

I assume the ICU as parameter should probably be maxICU instead, as it is initialized in the class? But I do not really see where the value of maxICU is actually used.

@twallema could you maybe clarify this?

twallema commented 4 years ago

maxICU is a relic from past implementations that can be removed.

stijnvanhoey commented 4 years ago

ok, thanks. And what about the parameter ICU' as input of thesystem_dfes` on line 224? Can also be removed?