search

UHIN / x12-parser-library

MIT License
15 stars 15 forks source link

Improvements on parsing #1

Closed Cleverson-Esales closed 5 years ago

Cleverson-Esales commented 5 years ago

Made some improvements on the parsing process to make the segment information reading easier

kclayton925 commented 5 years ago

Thanks for submitting the pull request. We will run it through our test files and ensure proper functionality for our use cases. Looks like we have already released a 1.0.4 version so we will have to resolve that.

markguyver commented 5 years ago

Let me start by apologizing for our delayed response to your pull request. We've had a lot going on in our organization and this project was temporarily forgotten.

I think the functionality you added (having a mapping for "pretty" names to access the segment elements) is a valuable feature and appreciate that you updated the documentation too; however, because of the style changes (i.e. spaces to tabs) as well as some other changes that have happened in the intervening time (namely, the addition of the HasProperties trait), I'm going to reject this pull request.

At the same time, we have resumed active development of this package with the intention of making significant changes which will include the feature that you've added. Thank you for contributing to our project and please feel free to continue being involved and submitting pull requests.