(Connector incompat) Terrestria incompatible with Regions Forge

UHQ-GAMES-MODS / REGIONS_UNEXPLORED_FORGE

12 stars 8 forks source link

(Connector incompat) Terrestria incompatible with Regions Forge #80

Closed KirboSoftware closed 5 months ago

KirboSoftware commented 6 months ago

Describe the bug A mixin priority issue. Should follow fabric in this case.

Crash Logs see https://github.com/Sinytra/Connector/issues/552

How To Reproduce Use regions, connector and terrestria

Version Minecraft Version: 1.20.1 and plausible further Modloader Version:

Mod Version:

Screenshots

gniftygnome commented 5 months ago

I think this affects Fabric too? In any case maybe you could make the @Override be an injector instead, like ours?

https://github.com/TerraformersMC/Terraform/blob/1.20.3/terraform-dirt-api-v1/src/main/java/com/terraformersmc/terraform/dirt/mixin/MixinEatGrassGoal.java#L33

KirboSoftware commented 5 months ago

yea, this affects fabric as well. I made this more in a "hacky" way. So I would need to fix when I have the time. However I fixed this temp by making ours a lower priority (priority = 999) and seemed to work fine crash wise. However, I never really made a proper fix adress this issue.

KirboSoftware commented 5 months ago

This issue is also related to #93. Mainly tracking for fixing