UHaifa-IS / whgazetteer-mehdie

World Historical Gazetteer - MEHDIE version
http://whgazetteer.org
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Parent not appearing in mehdie #130

Closed sinairusinek closed 1 year ago

sinairusinek commented 1 year ago
Screen Shot 2023-09-20 at 11 03 43

the Parent (in the Yaqut dataset) appears in its own column but does not appear in the gui.

tomersagi commented 1 year ago

The problem is traced to the Hit model used to store a hit result. The results on the right side come from this table, and the table does not contain the type and parent information. Moreover, there is no reliable way to link the hit to a place in the place table or the relevant tables for this information: 1) place_type and 2) place_related for which one needs a place_id. The hits table and Hit model do not contain the place_id for the related place, only a src_id (string) which is not unique in the place table.

tomersagi commented 1 year ago

To remedy the situation:

tomersagi commented 1 year ago

@sinairusinek this fix (when done) will solve #131 and #128

tomersagi commented 1 year ago

Hit now contains a method to extract the other place, but I am pretty sure we cannot use that in order to get a runtime result for parent and type. We need to somehow incorporate these in the context transferred to the HTML page. Perhaps using the FormSet object.

tomersagi commented 1 year ago

Type is now showing correctly. Now working on parent.

tomersagi commented 1 year ago

All done image