UHaifa-IS / whgazetteer-mehdie

World Historical Gazetteer - MEHDIE version
http://whgazetteer.org
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Linking review not taking effect #145

Closed tomersagi closed 1 year ago

tomersagi commented 1 year ago

When reviewing match results, selecting a same-as and saving does not have any effect.

tomersagi commented 1 year ago

The problem is that the formset is failing validation with the following error:

 [DEBUG] entered POST for review page, place_id: 107727, review_status: None
Nov 07 16:53:27 mehdie-gui gunicorn[101946]: Review Status is None, value of review_status==1 is False and value of formset.is_valid is False
Nov 07 16:53:27 mehdie-gui gunicorn[101946]: [DEBUG] formset is not valid
Nov 07 16:53:27 mehdie-gui gunicorn[101946]: <ul class="errorlist"><li>authority<ul class="errorlist"><li>Select a valid choice. 241 is not one of the available choices.</li></ul></li></ul>

This is possibly because we are trying to record the other dataset ID somewhere that is not designed for this in the Django system.

tomersagi commented 1 year ago

Fixed by removing the validation over the authority field to be from a list of authorities since we now use this field to list datasets.

MoranZaga commented 1 year ago

image

MoranZaga commented 1 year ago

הבעיה היא שבלחיצה על אחת מהאפשרויות בתפריט הדרופ-דאון הוא מוביל למסך שגיאה

tomersagi commented 1 year ago

problem is traced to the fact that the authority field in the hits table has the string 'md' in it instead of the dataset id for the task (in this case 256).

tomersagi commented 1 year ago

Code was updated October 30th. The problem hits where created on October 29th so the problem is already solved.