search

UI-Research / college-affordability.urban.org

0 stars 0 forks source link

Increasing the left margins of line graphs #163

Closed vivhou closed 7 years ago

vivhou commented 7 years ago

Some of the graph is being cut off (the tick label is showing, just the point is being cut off). For example, 04_0100.json:

screen shot 2016-12-02 at 4 11 37 pm

vivhou commented 7 years ago

I fixed this by adding to the top level:

"padding": {"left": 50} screen shot 2016-12-21 at 2 01 44 pm

bchartoff commented 7 years ago

Thanks for taking a look! But unfortunately this issue is still open. It may not be apparent, but it's related to #153 actually, so I'm working on some padding and tick label solutions.

The top level padding object actually adds padding to the left of the ticks, not between the ticks and the data. So, an exagerated example, "padding": {"left": 200} produces:

image (didn't push this change, just as a demonstration).

Working on right/left padding by adding additional data points at the start and end of each line chart, then hiding the tick marks, see 923b821b6d006f6aa871d38bd5c6b0cba569663b , but this solution is not complete, yet.

Also, for future issues, it's best practice to commit the fix (I don't see any commits with the left padding you mentioned above), then paste the commit id into the message that closes the commit. I'm not always good about doing this, but it's an ideal best practice!

Thanks for taking a stab, I'm reopening, and am working on these related issues (related to #153 )

bchartoff commented 7 years ago

Should be fixed programatically, hand corrections handled by #182