Labels sporadically not appearing

[vivhou]

When adding "labels" to a graph, this sometimes does not appear, I'm not so sure why this is inconsistent. For example, the multiples for 02_0071.json through 02_0073.json have "labels": {"format": "dollar"}, but you don't really see all of the labels. On the contrary, 02_0081.json through 02_0083.json have the same code and you can see the labeling:

[bchartoff]

closed by 87598a5f6596ad802f80ce196ee3dc7e9b79fc12

[vivhou]

I noticed the graph above (in cost-of-educating/subsidies), still looks like this, should we just leave as is?

[vivhou]

Oh whoops, I forgot to pull your changes, no wonder! It's working now 👍

[vivhou]

Actually I noticed in this graph, the labels for the black bar aren't always appearing (financial-aid/institutional 04_0211.json through 04_0213.json )

[bchartoff]

Good catch! But not this issue, actually, the text exists but is getting cut off bc the y maximum value is too small.

Corrected by e3c2fb0bf89e1345a752752e6b60d9fe18c4a65c

Reclosing. @vivhou please keep a look out for similar cases with incorrect ymax's, I will as well

[vivhou]

Gotcha, thanks for noticing this! I made the other ranges in the multiples the same as well to keep this consistent, and noted these changes in the R code and master sheet. However, I notice that now the graph looks like this, should I open a ticket?

[bchartoff]

You mean the collision with the Source line? No, I've added padding locally, I'm pushing now, commit a93e2c05f882fb7bf4cd90c0f0f905e22793112b

[vivhou]

great thanks!