UI-Research / college-affordability.urban.org

0 stars 0 forks source link

Add optional subtitle field #197

Closed bchartoff closed 7 years ago

bchartoff commented 7 years ago

Allow for subtitle for both regular and small multiple charts

bchartoff commented 7 years ago

Should be all set, @vivhou please see cfdf828e66bb7549f6f25f2a667647ab21f5b35f for single graphs and 7d483b4aad38a4cb5bc4669e456aa81e8ae933d8 for small multiple graphs. Examples of implementation are in changed files. To close, please:

vivhou commented 7 years ago

This looks good, except do we want to make it bold or even increase the spacing between the title and subtitle, just so it stands out? Or we can leave as is and see if everyone else is fine with it!

screen shot 2017-01-18 at 8 40 23 am

bchartoff commented 7 years ago

Good call, really should have tackled this earlier, but these titles don't align to style guide, since line height is way too big. I think updating line heights and spacing helps, what do you think @vivhou ?

Commit c54e8f7d8cf267efd7bb8192fc2b4284f548b26e

New title/subtitle: image

Style guide title/subtitle: image

Two images overlayed: image

vivhou commented 7 years ago

Yes that definitely looks much better, thanks!