UI-Research / college-affordability.urban.org

0 stars 0 forks source link

Remove custom format strings #201

Closed bchartoff closed 7 years ago

bchartoff commented 7 years ago

A large number of charts have custom format strings for labels and axis ticks, all format strings should be dollar, number, or percent, unless there's a need for some custom string, which we can chat about.

I don't know which edits were made by hand and which were in the R script. I've changed a handful back by hand for the purposes of testing the new formatting logic. I did not realize you were changing so many format strings in the R scripts/by hand, sorry to make you reverse the work.

To see all files with non standard format strings, you should be able to run:

egrep -rl "\"format\"\: \"[^dnp]" pages

From the project root. That recursively greps through pages, looking for chunks of text that start with "format": ", then are followed by any character other than d, n, or p (for dollar, number, percent).

bchartoff commented 7 years ago

Ok, so I removed these by hand with this commit: d5d35ec5bf44ded8bc59126f53a9bf5dd67ffb9c

But I'm leaving this open, in case you still need to update R scripts etc @vivhou

vivhou commented 7 years ago

thanks ben! i'll change the appropriate R scripts so that they are one of the 3 format strings

vivhou commented 7 years ago

if i change the R scripts to the right format string, should i also change this in the json? this is overridden correct?