search

UI-Research / college-affordability.urban.org

0 stars 0 forks source link

Horizontal bar chart overlapping with Source/Notes line #204

Closed vivhou closed 7 years ago

vivhou commented 7 years ago

In rotated graphs, the bottom collides with the Source/Notes line. This example is from financial-aid/tax-benefits 04_0260.json but also applies to 04_0270.json

screen shot 2017-01-24 at 11 31 57 am

vivhou commented 7 years ago

Another example from covering-expenses/savings 05_0280.json: screen shot 2017-01-24 at 1 49 16 pm

vivhou commented 7 years ago

added padding to bottom

vivhou commented 7 years ago

In prices-and-expenses/tuition-and-fees for 03_0030.json, this seems to be a bigger issue that padding can't solve. I manually added size.height:600 and this is what it looks like: screen shot 2017-01-27 at 10 50 13 am

bchartoff commented 7 years ago

Right, it's not straightforward to add height to a chart as we've discussed, since it also requires custom css for the chart wrapper, see https://github.com/UI-Research/college-affordability.urban.org/commit/529a4b4755a021121d333653df8dffd99727dde4

That being said this is fixable by expanding the space alloted for the axis labels, see https://github.com/UI-Research/college-affordability.urban.org/commit/15a1ae047de1a74df3fae701776b47aa76c3d8c0#diff-c66e3b1f01f13565a09ae2cc6cc66c3aR1 (axis.y.padding.left set to 200). I pushed but did not update the hand edit markdown file or the R scripts. Please go ahead and update one of those 2 documents, then go ahead and mark this issue closed again.

After that, hands off for now!

bchartoff commented 7 years ago

@vivhou reminder that this bug came back up in Victoria's chart edits, take a look, see if fixable, and close issue (after updating in R or markdown). Thanks!

bchartoff commented 7 years ago

This issue has meandered a bit, but where it ended up is a duplicate of #213 , so closing