search

UI-Research / college-affordability.urban.org

0 stars 0 forks source link

Spacing below (line) graphs #206

Closed vivhou closed 7 years ago

vivhou commented 7 years ago

There is a larger amount of space under certain graphs, which happen to be line graphs. Example 1 from Covering-expenses/savings 05_0250.json screen shot 2017-01-25 at 9 05 02 am

Example 2 from Covering-expenses/working-during-college 05_0070.json screen shot 2017-01-25 at 9 11 06 am

vivhou commented 7 years ago

ben, did you say that this issue might not be resolved?

bchartoff commented 7 years ago

No, I do not see a way to easily resolve it. More importantly, if it were resolved, it would effect every chart, so charts that currently do not have spacing problems would end up overlapping with the source/notes section, I believe. Basically it'd be a massive QC effort for every chart on the site. What prompted you to reopen?

vivhou commented 7 years ago

Elizabeth had mentioned this issue in 2 graphs in the QC edits, but since it's only 2 graphs, and we can't fix it without having it affect other graphs, then i'm going to close this.

bchartoff commented 7 years ago

Lol lots of closing and reopening here...@vivhou if it's only for a few graphs, can you fix them by tweaking the size property in the json?

vivhou commented 7 years ago

yes haha that works! don't know why i was overthinking this