search

UIUCLibrary / Digital-Exhibits-Issues-Features

0 stars 0 forks source link

"See more" on faceted browse does not work on Freedom theme #10

Open graykr opened 5 months ago

graykr commented 5 months ago

When you set up a facet, you can specify a max number of values to initially show. If the number exceeds the max, the facet will show "See more (#)" at the end of the list. You should be able to click this and have all the values show. However, on the Freedom theme, this does not work. When I switched to some of the other themes (center row, default), the functionality worked as expected.

Sandbox example: https://scp.library.illinois.edu/omeka-s/s/test-ihlc-oral-histories/faceted-browse/1

Production site example: https://exhibits.library.illinois.edu/s/ihlc-oral-histories/faceted-browse/3

As a temporary workaround, I can just not use the max value feature, but this is definitely a bug in the theme...

spenserbailey commented 5 months ago

Yep, I've run into this too!

spenserbailey commented 5 months ago

I could have sworn that it worked before on Freedom, but I might be thinking of when I was still using ksharp for our site.

alexdryden commented 4 months ago

I think this, and a few other things around pagination I found yesterday, are from some updates the theme made to be compatible with 4.1. The problem is that they don't push bug fixes back to prior stable versions, so in order to get the bug fixes you need to always be on the bleeding edge version. I think that we might be able to move to 4.1 now as a few other projects are wrapping up and no longer need the sandbox to match IOPN prod exactly, at least for a bit.

alexdryden commented 4 months ago

@graykr what is your time table for going live? If I'm not able to get production to 4.1 in time, I may need to back out of the current version of Freedom and cherry pick some of the bug fixes (e.g., escaped characters) to an earlier version to resolve this issue..

graykr commented 4 months ago

@alexdryden This issue isn't important to fix before we do a soft launch (I'm hoping by the end of the week?). We don't (yet) have an overwhelming number of subject or community terms, so I can just not set a limit on the facets to have all the terms display for now.