Editing a footnote breaks EW

UIUCLibrary / scalarfootnotes

Manages footnotes for the Scalar WYSIWYG

GNU General Public License v3.0

0 stars 1 forks source link

Editing a footnote breaks EW #21

Open alexdryden opened 2 years ago

alexdryden commented 2 years ago

If an editor makes a change to the footnote text, the author's accept/reject workflow will experience several major issues:

The footnote numbering breaks. The original footnote, the addition/deletion, and the return all become their own ul
When trying to save the accept/reject changes getting, clicking "Yes" has no effect and produces 'Uncaught TypeError: widgetElement is null' on plugin.js:2881 in the javascript console.

alexdryden commented 2 years ago

My first instinct for the numbering bug is that <cite> elements probably can't contain <span> so to fix it the editor closes the cite, li and ol and opens a new ol

alexdryden commented 2 years ago

For the second effect (can't save): Formatting without cite or ol makes no difference. Turning the footnotes plugin off before entering the EW allows saving, so there is something (probably the sanity check that makes sure there aren't dangling notes) in the footnote plugin that is breaking.

For the first effect (numbering): It seems that the editorial workflow might just have an issue handling ordered lists--needs further investigation.