search

UIUCSinhaLab / GEMSTAT

Thermodynamics-based models of transcriptional regulation by enhancers: the roles of synergistic activation, cooperative binding and short-range repression
6 stars 8 forks source link

No activators if no factor_info file provided. #30

Open bryan-lunt opened 9 years ago

bryan-lunt commented 9 years ago

The problem is that line

https://github.com/UIUCSinhaLab/GEMSTAT/blob/master/src/seq2expr.cpp#L331 ( Update: now https://github.com/UIUCSinhaLab/GEMSTAT/blob/master/src/seq2expr.cpp#L340 )

needs to change the "false" to "true".

Needs to be fixed on both main branches.

bryan-lunt commented 9 years ago

Definitely my fault.

bryan-lunt commented 7 years ago

The code should be fine now, can we close this?

Not until we have a regression test to test it?