Closed sw-mattw closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.17%. Comparing base (
1f4b137
) to head (8922903
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
11.5% Duplication on New Code
Ignoring failing company house tests due to head branch ahead with recent company house API response change and possibly due to APIM migration.
Introduction :pencil2:
During bank report upload to portal, we occasionally observe floating-point rounding errors for numerical cells. These are presented as validation errors (see screenshot below), meaning the report cannot be submitted.
Facility utilisation values of
3938753.80
and761579.37
are two examples of this.A spreadsheet with this issue has been attached to the ticket itself.
This affects production.
Validation errors for the above figures: Note that the value displayed in Excel (3938753.80) does not match the value in the entry column of the first row (due to this rounding issue).
Resolution :heavy_check_mark:
1e-6
of the original figure. If it is, we take the rounded value, otherwise we use the original figure. This approach means we can still handle genuine errors such as12.345
(which isn't 2 DP, but is not a floating-point rouding error either).Miscellaneous :heavy_plus_sign:
N/A