UK-Export-Finance / dtfs2

Digital Trade Finance
MIT License
11 stars 1 forks source link

chore(DTFS2-7393): refactor facility end date feature flag e2e-tests/gef #3567

Closed MarRobSoftwire closed 1 month ago

MarRobSoftwire commented 1 month ago

Introduction :pencil2:

We want to refactor how ffs are tested to remove the if statements from tests.

Resolution :heavy_check_mark:

Note ⚠️

I'll break this work into smaller chunks. The rest of the facility/ test suites need the same doing

MarRobSoftwire commented 1 month ago

@ttbarnes @abhi-markan This PR is still in draft - I want to make sure everything is up to date before I copy the files and update the test.yml file

abhi-markan commented 1 month ago

Does test.yml need updating?

It does as these tests will be executed under both the jobs e2e-tets-ff (FF enabled) and e2e-gef (FF disabled).

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
70.6% Duplication on New Code (required ≤ 40%)

See analysis details on SonarCloud