feat(FN-2311): add frontend payment details filtering logic - Githubissues

UK-Export-Finance / dtfs2

Digital Trade Finance

MIT License

11 stars 1 forks source link

feat(FN-2311): add frontend payment details filtering logic #3646

Closed sw-mattw closed 2 weeks ago

sw-mattw commented 3 weeks ago

Introduction :pencil2:

The payment details tab filtering requires integration with the backend in order to filter the table data.

Resolution :heavy_check_mark:

Added frontend validation of filter values, including error states and value persistence (see screenshots)
Connected frontend with the relevant backend work (passing filters down)
Added 'no results found' message when filters applied and no results
Added payment currency mapping to radio input options (see screenshots)

Miscellaneous :heavy_plus_sign:

Pulled out shared type ValidatedPaymentDetailsFilters from dtfs-central-api and moved to libs/common
NOTE: E2E tests will be added under a subsequent PR - there is a slight issue on the backend with correctly filtering all payments meaning we can't check the validity of rendered payments at present.

FN-2311_PR-3646_filters-panel FN-2311_PR-3646_filters-applied FN-2311_PR-3646_errors

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.0% Duplication on New Code

See analysis details on SonarCloud