UK-IPOP / drug-extraction

A ToolBox for fuzzily extracting drugs mentions from text.
https://drug-extraction.vercel.app
MIT License
3 stars 0 forks source link

Specify rx-class-relasource #61

Closed nanthony007 closed 2 years ago

nanthony007 commented 2 years ago

Make --rx-class-relasource required to be one of MESH or ATC only.

This would be a huge improvement in stability.

There is also the need to improve the language and documentation around the --rx usage since Daniel misunderstood and searched for one rx-cui but we need to search for the --rx-class-id

nanthony007 commented 2 years ago

I'm thinking about removing this functionality and just defaulting to the ATC class... ultimately this functionality was added but it isn't used by us internally.

I think a larger concern is the clarity of the documentation. RxClass is quite confusing when most people think of RxNorm in their minds. Additionally finding the class-id and relasource are not straightforward...

nanthony007 commented 2 years ago

Decided this is not worth the hassle. Closing until a better reason emerges.