Update major changes for v0.2 - Githubissues

UK-IPOP / drug-extraction

A ToolBox for fuzzily extracting drugs mentions from text.

https://drug-extraction.vercel.app

MIT License

3 stars 0 forks source link

Update major changes for v0.2 #80

Closed nanthony007 closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drug-extraction	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2023 2:53am

nanthony007 commented 1 year ago

LGTM, just need some tests, especially for Rust lib.rs.

We will also need to pin versions and/or adjust dependent projects, primarily the opendata-pipeline

nanthony007 commented 1 year ago

We will also need to publish both CLIs to PyPI. For this we need to adjust each CLI's pyproject.toml accordingly.

nanthony007 commented 1 year ago

Also... adjust READMEs

nanthony007 commented 1 year ago

After dogfooding for a bit there appear to be a few issues... namely:

[ ] pipe subcommand doesn't have any progress state and has output dis-similar to that of the standard sub-command
[ ] the loading terms section is not parallelized and takes much too long, sometimes longer than the search itself
[ ] there is inconsistency between the subcommand options/flags and their character formatting... this also doesn't follow common unix patterns people will be expecting...

Good news is the tool is looking very useful. Further, it works quite well that the interactive subcommand relies on the standard subcommand as this reduces complexity and means interactive is only for generating the config. This is good practice for expanding to other UI modals, i.e. desktop.

After adding some tests, we will need to think about our release and how we want to version this for all 3 toolkits... that being said, do we want to take this time to release a desktop app as well?

nanthony007 commented 1 year ago

We made some significant changes but this worked out and looks good now