Update visit and base form properties

UK-SBCoA / uniform-data-set-dotnet-api

.NET Core web api for the NIA's ADRC Uniform Data Set (UDS)

BSD 2-Clause "Simplified" License

1 stars 0 forks source link

Update visit and base form properties #63

Closed ashleybot closed 3 months ago

ashleybot commented 4 months ago

Fixes #62

This PR adds all base properties for forms that UDSv4 now includes:

[ ] MODE
[ ] RMREAS
[ ] RMMODE
[ ] FRMDATE
[ ] INITIALS
[ ] Renames existing properties to the correct naming convention from NACC UDS documentation
[ ] This PR also does some minimal refactoring by cleaning and simplifying repetitive code.
[ ] Migrations to update all forms with base properties and SQL view for form summaries

You will need to test solely with back-end, or also pull sibling PR for front-end to test.

ashleybot commented 4 months ago

@mlan225 Can you review this PR?

mlan225 commented 4 months ago

API code looks good, Noticed that it looks like we'll be keeping the removed properties as commented code from the Update function in the dto to entity mapper in case we want to allow for these properties in the future.

Going to look over and test the web interface with this API branch, but the API itself looks good ✅

ashleybot commented 4 months ago

@mlan225 Also updated the api with a commit, but unrelated to what you were seeing with visit creation.

ashleybot commented 3 months ago

@mlan225 will merge into main