Add the disable functionality

mlan225 commented 8 months ago

Resolves: #83

List of changes and additions made to the C1 functionality

[ ] Validation message added to question 1 other field
[ ] No validation message for 1a1 other field when error, just the red outline
[ ] 2b other field does not display error message
[ ] 3a cannot be completed with an input of 88/88/8888 (unknown), but it CAN be partial saved. CAN be accepted on a valid date for completion
[ ] 3a1 does not follow validation range of the pdf guide (0 - 25) all values are accepted
[ ] 3b validation is checking the wrong range, won't accept 10 or 20
[ ] 4a not accepting 10 on its 0-17 range (it accepts 1)
[ ] 12a not accepting input of 40
[ ] Question 8b does not save when submitted
[ ] Add in required if range for optional inputs

Reviewing the form

The form is pretty straightforward to follow. Optional inputs are required after being enabled, all parent inputs are required to have values on completion. Range inputs enable child fields within valid range. Following the error messages after trying to complete a blank form should give you a roadmap for checking.

Required for testing

You will need to run the web PR alongside this PR here: UK-SBCoA/uniform-data-set-dotnet-api#19

ashleybot commented 7 months ago

@smiththay Could you review this PR?

mlan225 commented 7 months ago

Good catch @smiththay, added the regex validation range to LOGIPREV

UK-SBCoA / uniform-data-set-dotnet-web