Milestones

[ashleybot]

• [ ] Create set of pages to view milestones, add, and edit milestones.

/Pages/Milestones

• [ ] Update participation details page with a html table of milestones (underneath visits).

[mlan225]

Hey @ashleybot in the meantime while I build out the views, I wanted to ask about the milestone data that we want to show up on the participations view.

On the UDS application we have it set up like this:

In the milestone model in the api, I don't believe I see properties for the Type (or "kind") and Details. Right now im displaying the minimum available data on the participations view. The Kind property for milstones seems like it will function a bit differently than the kind or type for a form object, but currently does not have something for it.

I'll have a better POC of what im currently doing with it after I create the additional views, but I'm keeping in mind that we may want to apply the additional functionality for "miestone type" and "details" as I continue to build things out.

[ashleybot]

The Milestone type in the screenshot can be determined by which questions the user completes. To summarize, if DECEASED == 1 || DISCONT == 1 then the "type" is Change followed by no further contact, otherwise it is Change followed by continued contact.

It might help to take a look at the paper form and DED documentation https://naccdata.org/data-collection/forms-documentation/standalone

[mlan225]

Ran into and worked through some interesting things last week. Kind of a lot of text here so we can walk through it next time we are able to discuss things:

• Custom attributes are checking for a type of FormModel, and since we talked about a Milestone not being a "form" and not inheriting from formModel, the custom attributes such as "required if" will need to have an additional file added that works with non formModel types.

• I had to do a little bit of a workout around when getting a single milestone. As of now there is only a route for getting all milestones within a participation. On the web project, I just had to get the collection of milestones and then further filter in order to have a single milestone for the edit functionality
• Modified the API, but in a way that does not adjust any existing contracts. There was a comment regarding this that you had some previous concerns about and I found to be true, so I adjusted the query/variable pair. The argument for putMilestone was initially Id and milestoneId instead of formId and it was indeed causing the issue stated above in the comment

• Attempted to make a partial to share between the create and edit views to remove some copied code, however, using the partials showed some issues when attempting to use the form behaviors on the pageModel. Didn't want to dive deep through creating a component and moving the logic, so for now i'll leave the views for edit and create as similar

[mlan225]

Running into a weird issue where the milestone type that is experiencing a mix of issues between setting the way the behaviors on the model are ran and setting the value for the milestone type.

Going to remove the behavior from the milestone type for now to continue development. In the future, it may just be easier to include MilestoneType as a property on the M1. It is not currently, but it is included on the M1 model in UDS, which leads me to believe it may just be missing.

[mlan225]

All functionality has been implemented. Cleaning up span numbering and going to check back on any TODO comments before submitting PR