Add blank table to participation page

mlan225 commented 7 months ago

Resolves: #102

Requires this PR of the uniform data set api: https://github.com/UK-SBCoA/uniform-data-set-dotnet-api/pull/20

Add milestones

Participation details

(https://localhost:4811/Participations/Details/id)

[x] Milestone added to the participation view
[x] Details for milestones in the participation details table display when 2a is given a value and 2b has at least one checkbox marked
[x] Can "create milestone" with the create new button
[x] Can edit milestone with the "edit" link
[x] Can view milestone details with the "view" link

Milestone Edit & New views

(edit link or 'create milestone' button on participation details view)

[x] Milestone type of 1 will disable Box B and MilestoneType of 2 will disable Box A
[x] Validation messages display upon submitting null data when the field is required (submitting a new empty form will give a good idea of the required form fields)
[x] Can save Milestone
[x] Editing milestone loads the correct values

ashleybot commented 6 months ago

Created a card to work on custom tag helper in the future.

ashleybot commented 5 months ago

@smiththay and @mlan225 paired last week!

ashleybot commented 5 months ago

[x] Date validation should allow 99 for month or day.

Screen Shot 2024-01-17 at 10 35 59 AM

mlan225 commented 5 months ago

Fixed the linter errors

mlan225 commented 5 months ago

Did some smaller additions to the UI to improve the section readability. Didn't seem to see existing examples for splitting a form of a similar style as we have here with 2 box sections with multiple sub-sections within.

If you feel like we would want to, I can put sections 5 and 6 into their own styled boxes to help separate them visually. Putting a horizontal line under each number didn't seem like a good idea because we wanted to still split Box A and Box B sections, so adding more lines would lose that. I could also pull Box A and Box B into their own styled containers as well if need be

ashleybot commented 5 months ago

@mlan225 Let me know when this is ready for review

mlan225 commented 5 months ago

Posting screenshots of updates to the form and a screenshot of the full form

Screenshot 2024-01-25 at 2 00 51 PM

Screenshot 2024-01-25 at 2 08 01 PM

Screenshot 2024-01-25 at 2 12 24 PM

screencapture-localhost-4811-Milestones-Edit-2024-01-25-14_16_35

ashleybot commented 5 months ago

@mlan225 The backgrounds around DEATH and DROPPED really help. Can the pills/badges for 3a's answers be adjusted to not have periods?

And I agree that Box A and Box B need some more visual differentiation, take a look at some example css in https://tailwindui.com/components

mlan225 commented 5 months ago

Restyled the milestone form layout:

[x] Added more visual differentiation to boxes A and B
[x] adjusted the appearence of the 5.Death and 6.Dropped sections

screencapture-localhost-4811-Milestones-Create-2024-01-29-09_37_01

ashleybot commented 5 months ago

@mlan225 The UI is shaping up! Let's talk in our 1:1 about shoring up some things with the underlying code next.

ashleybot commented 5 months ago

To-do

[x] "M1 Milstones" should be "M1 Milestones"
[x] "Which milesone" should be "Which milestone"
[x] "Reasons(s) for change inidcated" should be "Reason(s) for change indicated"
[x] Any other typos?
[x] Delete Base.cshtml and move Base.cshtml.cs to a PageModel (you don't need a view for BaseModel) Rename it MilestonePageModel.cs (it's not the base for everything) Use VisitPageModel as an example.
[x] Remove M1.cs file
[x] Labels and comments in MilestoneModel need to be cleaned up. Double check code in COA.UDS.
[x] Isvalid could be a protected rather than public method. Watch formatting and naming conventions.
[x] Check comments and clean
[x] Validation for 2a1 should be enabled and required if 2a. = 1 or 2
[x] Add note for Minimal contact "NOTE: Minimal contact status is reserved for participants who can no longer participate for one of the reasons listed in Question 2b, below."
[x] "co-participant" should be used rather than "informant"
[x] Fix 6d "co-paprticipant" to "co-participant"
[x] Update instructions "INSTRUCTIONS: Please submit a new Milestones Form as soon as possible after each milestone event has occurred."

mlan225 commented 5 months ago

Moving into the review, addressed 1 on 1 comments (checklist above has the marked changes)

screencapture-localhost-4811-Milestones-Edit-2024-01-31-10_48_39

mlan225 commented 5 months ago

Something to point out is that because of the client-side validation for the milestoneType on the view, if a user selects NO FURTHER CONTACT for milestone type but then forgets to input an option for deceased or withdrawn

Screenshot 2024-01-31 at 11 51 54 AM

Then when the page reloads to show the validation errors, the milestone type WILL be changed after identifying that deceased or withdrawn are not selected, and setting it for continued contact. This is because when a form is loaded with either a deceased or withdrawn value, milestone type will need to be set to identity this as continued contact because they are neither deceased or withdrawn.

Screenshot 2024-01-31 at 11 52 01 AM

Steps to reproduce:

create a new milestone form
set milestone type as 0. No further contact
Do not check deceased or withdrawn
Submit form and see that milestone type value has been changed and is now disabling box B

ashleybot commented 5 months ago

Something to point out is that because of the client-side validation for the milestoneType on the view, if a user selects NO FURTHER CONTACT for milestone type but then forgets to input an option for deceased or withdrawn...

@mlan225 This is good to point out. I'll create a card and we can iterate on it in the future.

UK-SBCoA / uniform-data-set-dotnet-web