A4a UI

[smiththay]

fixes #134

[ashleybot]

@mlan225 and @smiththay paired yesterday! :-)

[ashleybot]

@smiththay Saw a slight label change in NACC's repo => https://github.com/naccdata/uniform-data-set/pull/145/files

[ashleybot]

@mlan225 Can you review this PR?

[smiththay]

Question 1 will activate all entries in the table for clinical treatments and/or trials. NACC docs don't show a way to enable specific number of rows. This functionality will remain as it is currently implemented until further testing by clients is conducted.

[mlan225]

Looks good, but there were 2 things that we already talked about earlier. I'll throw them on here for records sake:

1. I asked if we'll need some additional for the table questions. It seems you have some good direction to move forward with that
2. Looks like the instruction text was updated a couple of days ago, lol not much we can do about keeping this up to date especially while in PR review or post review until we figure out a system for checking in on these. But while we are here, might as well updated it 🤷

[ashleybot]

@smiththay Let's pair during our one-to-one on enabling/disabling and validation within child partial views

[smiththay]

@mlan225 Ready for another review.

[mlan225]

Heyo @smiththay, validation looks great! I did notice one small thing with the checks for last 2 columns.

Looks like the second to last column in the tables only check for the second option radio option "clinical trial" and ignores option 3 "clinical care and clinical trial" for a valid check. Is this intentional?

Option 3 selected and marked complete

Option 2 selected and marked complete

The rules in the documentation for the question in the screenshot states:

If CARETRIAL3 is 2 or 3 then TRIALGRP3 cannot be blank

[smiththay]

@mlan225 thanks, that was an oversight on my part and has been addressed and ready for another look through

[mlan225]

Awesome, Looks good to me ✔️