search

UK-SBCoA / uniform-data-set-dotnet-web

.NET Core implementation of UDS with MVC and Razor Class UI Library
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

B3 #151

Closed Oddvocado closed 2 months ago

ashleybot commented 3 months ago

@smiththay Can you review this PR?

smiththay commented 2 months ago

@Oddvocado - The B3 looks great and functions correctly, there are just a few things that need to be shored up before this is ready to merge.

1.) For question 11, there seems to be a description with the question but this doesn't exist in the NACC doc. Screenshot 2024-04-05 at 3 59 49 PM Screenshot 2024-04-05 at 3 59 40 PM

2.) I believe the mistake was that the description belonged here under question 13 instead of question 11. Screenshot 2024-04-05 at 3 58 30 PM Screenshot 2024-04-05 at 3 58 40 PM

3.) On question 2, the " � " symbol is wrapping poker face instead of quotes. Screenshot 2024-04-05 at 3 54 42 PM Screenshot 2024-04-05 at 4 12 27 PM

4.) On question 2, the " � " is displayed rather than 1/4. Screenshot 2024-04-05 at 3 54 51 PM Screenshot 2024-04-05 at 4 12 41 PM

Oddvocado commented 2 months ago

Should be fixed now!

smiththay commented 2 months ago

@Oddvocado Looks good!