search

UK-SBCoA / uniform-data-set-dotnet-web

.NET Core implementation of UDS with MVC and Razor Class UI Library
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

C2 #157

Closed Oddvocado closed 2 months ago

Oddvocado commented 3 months ago

Updates UDS3 C2 form to UDS4 Fixes #154

ashleybot commented 2 months ago

Flexbox, responsive design

Screen Shot 2024-04-10 at 10 13 20 AM

Possibly upgrading label tag helper to make rendering of variable name optional (but default to true) https://learn.microsoft.com/en-us/aspnet/core/mvc/views/tag-helpers/intro?view=aspnetcore-8.0

ashleybot commented 2 months ago

Can you take a look at this PR @mlan225 ?

mlan225 commented 2 months ago

The form looks good to me! The form functions as intended and I could not find any issues with submission and saving.

There are 2 things I wanted to bring up unrelated to the functionality of the form, but still relevant to the forms existence:

  1. Smith pointed out to me that there is some tailwind selector code we've been using for checkbox disables. disabled:bg-slate-50 disabled:text-slate-500 disabled:border-slate-200 disabled:shadow-none. Having the disable style will add shadowing of the disabled checkboxes, so it can be more immediately visible.

  2. This is also something I'm not super sure about, and may have to verify with my own PR. But the form is currently only available as IVP. I believe we also usually include TIP with that as well, as it is an in-person visit over the phone, It might be good to verify with @ashleybot how we can identify which form kind we can associate with each form and how we can correctly assume these connections.

Oddvocado commented 2 months ago

@mlan225 Went ahead and added the styling to the checkboxes, glad you caught that.! Also, talked with @ashleybot earlier today regarding the form kind as was told to reference the UDS3 documentation for now https://naccdata.org/data-collection/forms-documentation/uds-3 . I went ahead and added the FVP to the form contract.

Ready for another pass!

mlan225 commented 2 months ago

Looks like you resolves all my previous issues 👍 , looks good to me after resolving the conflict ✅