Update B9 - Githubissues

UK-SBCoA / uniform-data-set-dotnet-web

.NET Core implementation of UDS with MVC and Razor Class UI Library

BSD 2-Clause "Simplified" License

1 stars 0 forks source link

Update B9 #159

Closed mlan225 closed 1 month ago

mlan225 commented 3 months ago

Resolves: #142

mlan225 commented 2 months ago

Missing CANNABUSE variable for checkbox 12r1e in the API. This property would have the type of bool?

mlan225 commented 2 months ago

@ashleybot so the ol' "get to it after I finish up" caught up with me

There is a variable missing from the API that's present in the documentation that I mentioned in a comment. The CANNABUSE

The form itself, minus the missing question, is built out though so if you wanted anyone to review the form the only change after would be the added property (minus any review changes)

ashleybot commented 1 month ago

@mlan225 card for adding property to api https://github.com/UK-SBCoA/uniform-data-set-dotnet-api/issues/56

ashleybot commented 1 month ago

@Oddvocado Can you review this B9 PR?

Oddvocado commented 1 month ago

Looks good! Noticed a couple things

[x] CANNABUSE is missing UI behaviors
[x] If BEAHALL has a value of 1 ("Yes") BEAHSIMP and BEAHCOMP are not required. I didn't see this mentioned as a requirement here --> https://github.com/naccdata/uniform-data-set/blob/main/forms/uds/b9/form_b9_ivp_questions_and_vars.csv but the question does read in a way that would make me think 12i1 and 12i2 would required a response when 12i is marked as "Yes". Either way, thought it was worth mentioning.

Other than that everything looks good!

mlan225 commented 1 month ago

@Oddvocado I think you're totally right with that second one, the sub-questions SHOULD be required. I also added a requirement for the pair above those 2 you pointed out as well.

[x] Added CANNABUSE to the behaviors for BESUBAB. CANNABUSE should disable properly now when BESUABAB is 0 or 9
[x] BEAHSIMP and BEAHCOMP are required if BEAHALL is 1
[x] BEVPATT and BEVWELL are required when BEVHALL is 1