D1a UI - Githubissues

UK-SBCoA / uniform-data-set-dotnet-web

.NET Core implementation of UDS with MVC and Razor Class UI Library

BSD 2-Clause "Simplified" License

1 stars 0 forks source link

D1a UI #160

Closed smiththay closed 1 month ago

smiththay commented 2 months ago

fixes #155

ashleybot commented 2 months ago

@Oddvocado Can you review the D1a?

smiththay commented 1 month ago

@Oddvocado Thanks for those catches, ready for another review

smiththay commented 1 month ago

@Oddvocado good catch, ready for another review.

There is an issue that will have a separate card for. Checkboxes that are enabled/disabled by a radio button do not save initially if validation on the form kicks on but will save if reentered.

Oddvocado commented 1 month ago

@smiththay Looks good! Only thing I noticed was this curly bracket hanging out at the bottom of the form. Other than that looks like it is ready to merge!