Github Super linter update

[mlan225]

Update the super linter version and document any errors that result from the update

• In addition to super linter update, upgrade the checkout action as well

[mlan225]

On first check after update to superlinter v6

View full action run here: https://github.com/UK-SBCoA/uniform-data-set-dotnet-web/actions/runs/8786968800/job/24111065743

CHECKOV healthcheck missing

• Check: CKV_DOCKER_2: "Ensure that HEALTHCHECK instructions have been added to container images"

CHECKOV docker no user created for container

• Check: CKV_DOCKER_3: "Ensure that a user for the container has been created"

CHECKOV top level permissions set to write-all

• Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all" FAILED for resource: on(UDS.Net Web Docker image) File: /.github/workflows/container-release.yml:23-24
• Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all" FAILED for resource: on(Push image to DockerHub) File: /.github/workflows/push-image-to-dockerhub.yml:0-1
• Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all" FAILED for resource: on(Lint Code Base) File: /.github/workflows/super-linter.yml:0-1
• Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all" FAILED for resource: on(Package release) File: /.github/workflows/package-release.yml:0-1
• Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all" FAILED for resource: on(Unit Tests) File: /.github/workflows/unit-tests.yml:0-1

Warnings

• Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[mlan225]

Second push after fixing update 1 errors

• View full run action here: https://github.com/UK-SBCoA/uniform-data-set-dotnet-web/actions/runs/8790408317/job/24122355165

Shellcheck error, word splitting

• .github/workflows/package-release.yml:31:7: shellcheck reported issue in this script: SC2086:info:1:48: Double quote to prevent globbing and word splitting [shellcheck]

  31 |       run: echo "VERSION=${GITHUB_REF/refs\/tags\/v/}" >> $GITHUB_ENV
   |       ^~~~

• By adding double quotes around $GITHUB_ENV the variable will allow the command to enter as many different strings when running the command and it will all be accepted as a singular argument in the run command

Warnings

• actions/checkout@v3 warning to update still exists

[mlan225]

Third push after fixing errors with second push the checks all successfully pass

Warnings

• actions/checkout@v3 warning to update still exists

[mlan225]

Fourth push after updating the actions/checkout version to 4

• No errors, successful run