search

UK-SBCoA / uniform-data-set-dotnet-web

.NET Core implementation of UDS with MVC and Razor Class UI Library
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Update super linter version to 6 #163

Closed mlan225 closed 1 month ago

mlan225 commented 2 months ago

Resolves: #162

ashleybot commented 2 months ago

@mlan225 Some of these changes seem to be the result of solving linting errors within workflow files. We had talked about adding the .github directory to be ignored by the linter as one of the first steps.

Upgrading the linter and checkout action versions is a good, straightforward thing, but we should minimize the scope of these changes as much as possible to prevent unexpected regressions.

mlan225 commented 1 month ago

Checkov, the package that is detecting the errors in the dockerfile and github files can be disabled via a environment variable. This seems like a short term solution to a bigger issue though, so I will attempt to get checkov to skip the github and dockerfile files still. The previous env variables and regex skips did not seems to work so far though. In addition, it seems the checkov is ignoring my attempts to skip the files through the superlinter env variables so far.

VALIDATE_CHECKOV: false

ashleybot commented 1 month ago

We can look at this together in our 1:1 @mlan225

ashleybot commented 1 month ago

It took me awhile to come full circle, but with @mlan225 's patience we reached a resolution.

With SuperLinter v6, we were having trouble figuring out the regular expression to correctly match the Dockerfile, so we’ll skip CHECKOV validation for now.

@mlan225 will create a card to come back and fix the Dockerfile errors it is reporting.