D1b UI

[smiththay]

fixes #156

[ashleybot]

@mlan225 Can you review this?

[mlan225]

Heyo @smiththay , got some comments to check out and verify whether these are issues or not 👍

• [ ] Paragraph text under question may want to be included
• [x] Clinician is spelled wrong in paragraph under question 2 (don't worry its spelled wrong in the document lol, not your fault)
• [x] On question 5, the option for (0) no says to skip to question 6b, but says to skip to 8 on the documentation. Was this something discussed before hand as a change?
• [x] Paragraph under 5 has a misspelling in the word clinician, also wrong on the documentation
• [x] In 6a, the (0) no option says to skip to question 8 when in the documentation says to skip to question 6b
• [x] For the behavior for 6b4, the 3rd option is looking for 2 instead of 9, which is causing 9 not function properly. This may be a consistent issue with other questions of the same type
• [x] Under question 14, it says "if present select one", but I can submit complete without selecting one. Is this intentional?

[smiththay]

@mlan225 good catches! Fixed everything but just wanted some clarity on the first point (Paragraph text under question may want to be included).

[ashleybot]

@smiththay Noticed some potential conflicts (it's out of date with main). Can you pull main into this feature branch? Let me know if you'd like to pair while resolving conflicts.

[mlan225]

@mlan225 good catches! Fixed everything but just wanted some clarity on the first point (Paragraph text under question may want to be included).

not even gonna lie to ya... I have no idea what I meant by that lol, but I'm not noticing anything it could have meant anymore, so 🤷‍♂️

[mlan225]

@smiththay Getting an interesting interaction with the form not saving the value for 7a, the value is being saved to the database, but the form loads up with no inputs selected. Can you check this on your end and see if its just happening to me?

[smiththay]

@mlan225 Thanks for the catch. I was able to replicate the issue. I fixed the behavior but unraveled a slew of other behavior issues but should now be in working order and ready for review.

[mlan225]

@smiththay Looks like those previous things were fixed up 👍 , something new I've noticed though is that CSFOTHX is not required when CSFOTH is 1, is this intentional?

[smiththay]

@mlan225 thanks for catching that! Updated

[mlan225]

@smiththay noticed a small text issue in the error message for question 1 and just wanted to verify some functionality for the checkbox section starting at question 12 to the end of the form

• [x] Question 1 error message: "The Were any biomarker results used to support the current etiological diagnosis? field is required."
• [x] Looks like 14c radio option is not required when 14 is present, should it be? 14c question text says: "if FTLD (QUESTION 14) is present, specify FTLD subtype)
• [ ] It also looks like questions 12 to the end, the checkboxes don’t' require a radio button to be selected, is this intentional?

For extra context on the last 2 points, I am able to submit this as a complete form. Selecting a radio option for 14a yields the same result:

[smiththay]

@mlan225 thanks again, I updated the message for Q1 and validation for Q14c. In regards to the radio buttons for Q12 and onward, they are not required.

[mlan225]

Smith is tackling the required tags for questions 8 and 11

[smiththay]

@mlan225 good eye! Good for another review.

[mlan225]

Looks good @smiththay ✅, I have no more nothings to say lol

[smiththay]

@mlan225 Thanks for having exceptional eyes!