Form Mode, Remote Reason, Remote Modality

[ashleybot]

Fixes #167

Custom tag helper for disabling options not allowed for certain forms

Example of REQUIRED form allowing remote

Example of optional form NOT allowing remote

Example of optional form allowing remote

This PR should

• [ ] Follow all form requirements outlined in UDSv4 documentation for whether a form is required or optional, or allows remote
• [ ] Adjusts allowed not completed reason codes according to UDSv4 documentation
• [ ] Adjusts allowed remote reason codes according to UDSv4 documentation
• [ ] Adjust form saving states to the In-progress or Finalized now that FormMode indicates whether the for is not included (NotComplete)
• [ ] Initials are required and the UX will be improved in a separate effort to autofill

[ashleybot]

To-do

• [x] Check data persistence
• [x] Check validation, should allow partial saves
• [x] See if ui behavior can be added to improve UX
• [x] Adjust save status to not include "Not included" option since this is now handled by form mode

[ashleybot]

We'll improve UX for initials here => https://github.com/UK-SBCoA/uniform-data-set-dotnet-web/issues/173

[ashleybot]

@mlan225 Can you review this PR?

[mlan225]

Running into an interesting issue when creating a visit. Running Api and Web PR branches and have run migrations on my local API database so things should be up to date on my end.

Can you confirm if the packet select options below are the intended options?

Also getting an error after attempting the creation of the visit above

[ashleybot]

@mlan225 Examiner initials will be handled more gracefully in #173 , but for now they need to be limited to 3 chars. So, that's why the create visit was failing. Should be good now. 👍

[mlan225]

• B6 MODE should allow in-person | remote | not completed but allows no options
• B6 NOT (not completed) reason does allow for a clickable option

[mlan225]

I was able to test the rest of the forms successfully, except for the C2 and C2T, after editing the required forms to be finalized, the F packet did not have those forms available.

The rest looks good though! The rest of it functions as promised after the B6 options are fixed ✅

[mlan225]

A literal non issue, but just mentioning it here so we know about it, but the styling for the applied validation messages when it is checked manually with an in progress status appear different than the ones checked against the model with intrusive validation

in progress error:

Finalized error:

[ashleybot]

A literal non issue, but just mentioning it here so we know about it, but the styling for the applied validation messages when it is checked manually with an in progress status appear different than the ones checked against the model with intrusive validation

Good catch. I would normally want something like this to be fixed, but we'll autofill these fields in future cards and so there won't be a big opportunity for them to be empty (end-user would have to jump through hoops).

[ashleybot]

@mlan225 Fixed B6. Handing this to @smiththay for a second pass since it has such a large affect-area.

[mlan225]

@mlan225 Fixed B6. Handing this to @smiththay for a second pass since it has such a large affect-area.

sounds good 👍