search

UK-SBCoA / uniform-data-set-dotnet-web

.NET Core implementation of UDS with MVC and Razor Class UI Library
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Configure app for AzureAD authentication #69

Closed mlan225 closed 1 year ago

mlan225 commented 1 year ago

Resolves #71

Remove the default identity login and replace it with azure AD authentication

mlan225 commented 1 year ago

This PR will be merged into a separate release branch, but for now I'll keep it pointed at main. We will change this once we find out where this will be going and what the branch will be called.

mlan225 commented 1 year ago

@ashleybot the azure AD authentication is working, however, there are some unknowns that i'd like to talk about whenever you get a chance to get into checking over this.

right now, you are able to login with your active directory credentials, but it seems that the scopes are currently unused. Would we want to set up another card to get the scopes to be required and set, or is that something we want to set now. I tried removing the scopes in the current code, but it still allowed me to sign in with my linkblue.

mlan225 commented 1 year ago

@ashleybot The site right now will launch the user into a sign-in prompt upon visiting the site. I've set up the researchers site to wait for the user to click the sign in link before asking for authentication. I can set it up like that here as well if we would like to allow for unauthenticated access to parts of the site.

we mentioned that this project will be on a different branch for internal purposes, so it may be safe to assume that everyone coming to this branch of the website will be Microsoft Entra (azure AD) accounts?

mlan225 commented 1 year ago

@ashleybot do you want me to set up the uds web production app registration and set up the appsettings.json for it in this task?

I wasn't super sure if we set up the registration on production registrations after we get the custom domain set up, since the redirect on our other prod apps seems to use the custom domain for auth redirects

mlan225 commented 1 year ago

PR has been squashed and merged into "release-azure-ad" destination branch via github desktop application and was not tracked on the github web UI.

Closing branch manually.