C1 Form UI Behavior and Finalization

[ashleybot]

Just the regular UDS 3 documentation https://naccdata.org/data-collection/forms-documentation/uds-3

[ashleybot]

Check out the C2 for examples on how to implement the client behavior, it's the in-person version of the C1 (~C1 is only for telephone visits~).

EDIT: I was wrong about the C1 being only for telephone visits. The C1 is an old C2 form for FVP, C2T is only for telephone visits.

[mlan225]

Disable functionality is all in, just going to give it one more check in the morning to make sure all existing functionality is correct. Came across one input where a range was not working correctly, so I'll be fixing that and checking the rest

[mlan225]

Putting down the rest of the fix checklist that'll be going through:

• [x] Validation message added to question 1 other field
• [x] No validation message for 1a1 other field when error, just the red outline
• [x] 2b other field does not display error message
• [x] 3a cannot be completed with an input of 88/88/8888 (unknown), but it CAN be partial saved. CAN be accepted on a valid date for completion
• [x] 3a1 does not follow validation range of the pdf guide (0 - 25) all values are accepted
• [x] 3b validation is checking the wrong range, won't accept 10 or 20
• [x] 4a not accepting 10 on its 0-17 range (it accepts 1)
• [x] 12a not accepting input of 40
• [x] Question 8b does not save when submitted
• [x] Add in required if range for optional inputs

[mlan225]

@ashleybot looks like its probably due to the range validation (I haven't looked too far into it and just assuming) but should we be able to submit the C1 as "complete" with an unknown date?

Here is the documentation:

And the application:

Just want to make sure before I look into it that we SHOULD be able to complete a form with a date of 88/88/8888 (unknown)

[ashleybot]

@mlan225 I am not an expert on the C1, but @smiththay has spent some time on it. Can you both review the NACC documentation and let's talk about it in stand-up tomorrow? The data-element dictionary probably has some good answers.

[mlan225]

Yeah, I'll fix up the straightforward ones and try and have a chat with @smiththay about it

[mlan225]

Talked Smith, will be adding the date fix and required on complete attributes to the form for this PR

[mlan225]

Pushed up any missing required attributes on optional and main questions and fixed a bug with a missing property in the api entity / dto conversions. There's an attached PR on the api for that.

Had some confusion with the radio button validation at first, it works but if there are other validation issues with other input types (strings, int, etc.) Looks like the validation will prioritize that and not show the radio button validation messages until they are they only ones left. Nothing wrong, just an interesting observation that could be helpful in case anyone in the future thinks something is wrong, and this could just be something with how the dotnet validation library works 🤷‍♂️