Publish image to DockerHub

UK-SBCoA / uniform-data-set-dotnet-web

.NET Core implementation of UDS with MVC and Razor Class UI Library

BSD 2-Clause "Simplified" License

1 stars 0 forks source link

Publish image to DockerHub #88

Closed ashleybot closed 4 months ago

ashleybot commented 10 months ago

https://github.com/UK-SBCoA/uniform-data-set-dotnet-web/blob/ffe03f57c1a0e526adf780eea40200d23dc71ae0/.github/workflows/container-release.yml#L31

Documentation: https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-docker-hub-and-github-packages

ashleybot commented 5 months ago

@mlan225 We have a DockerHub org, when you are back, let me know your dockerhub username and I'll add you. https://hub.docker.com/orgs/uksbcoa/members

ashleybot commented 5 months ago

Push the image on release

mlan225 commented 5 months ago

My docker hub info is:

username: mlan225 email: armbandit95@gmail.com

mlan225 commented 5 months ago

The release branch has been updated and the action to build and push to docker hub has successfully run.

i'll consider getting access to the docker org as part of this issue card, so i'll be standing by for the invite before moving this card to done

ashleybot commented 5 months ago

@mlan225 Sent invite to DockerHub UKSBCOA org

mlan225 commented 5 months ago

Created the workflow, but encountered an issue during the build phase of the workflow.

Some things to note that I have done:

Pushed the workflow through main into release in order to run the workflow and test it. Going to switch the workflow activation branch to a PR branch in order to keep from further muddying up the main and release branches with test workflows for this dockerHub push
Due to my dockerHub account being signed in through my github, I attempted to use a github access token as my password, but that did not seem to work. I switched over to a dockerHub access token as my password and that was able to log me in successfully
Modified some of the code form the instruction, changed on: release: to on: push: since we want to update on a push to release and im not sure we have an actual release workflow as opposed to just pushing to a release branch.

mlan225 commented 5 months ago

Image pushed to dockerHub using the test branch. Looking into setting the appropriate tags in the workflow.

This is under the assumption that we will want to push up tagged versions of the web application when we make updates instead of only having a "latest" version?

ashleybot commented 5 months ago

Just use the branch name to tag the image like the other workflows. So in this case it would be release.