search

UKCloud / openshift-deployment-ansible

3 stars 1 forks source link

Remove hard-coded hostnames #2

Closed charliejllewellyn closed 7 years ago

charliejllewellyn commented 7 years ago

It's bad practice to hardcode things. It should be dynamic incase we ever need to change hostnames in the future.

stevemul commented 7 years ago

did it test successfully?

charliejllewellyn commented 7 years ago

in isolation yes. I haven't tested a full deployment, kinda comes down to our pipeline conversation I guess. I would like testing to occur on this pull request.